Run KubeVirt integration tests on GitHub Actions#287
Merged
Jakob-Naucke merged 5 commits intoJun 26, 2026
Conversation
|
Skipping CI for Draft Pull Request. |
Reviewer's GuideRefactors integration tests and operator installation flow to support running KubeVirt-based integration tests in GitHub Actions, replacing ad‑hoc polling with kube runtime await_condition/timeouts, tightening test cleanup, and adding a dedicated Go module and CI workflow for virtctl/KubeVirt setup. Sequence diagram for updated operator reconcile installation flowsequenceDiagram
participant Reconcile as reconcile
participant InstallComponents as install_components
participant ReferenceValues as reference_values::adopt_approved_images
Reconcile->>InstallComponents: install_components(client, cluster)
alt [component installation fails]
InstallComponents-->>Reconcile: Err(e)
Reconcile-->>Reconcile: Action::requeue(Duration::from_secs(60))
else [component installation succeeds]
InstallComponents-->>Reconcile: Ok(())
Reconcile->>ReferenceValues: adopt_approved_images(client, cluster)
ReferenceValues-->>Reconcile: Ok(())
Reconcile-->>Reconcile: Action::await_change()
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Jakob-Naucke
force-pushed
the
gha-kubevirt
branch
from
9ae710e to
ed83a9e
Compare
Member
Author
|
/ok-to-test |
Jakob-Naucke
force-pushed
the
gha-kubevirt
branch
8 times, most recently
from
98fb28f to
2be922c
Compare
Jakob-Naucke
force-pushed
the
gha-kubevirt
branch
from
2be922c to
f3e5378
Compare
Jakob-Naucke
force-pushed
the
gha-kubevirt
branch
from
f3e5378 to
47afcbe
Compare
Member
Author
|
first pass, 3 passes in a row & I'm happy |
Jakob-Naucke
force-pushed
the
gha-kubevirt
branch
2 times, most recently
from
b95e93a to
ffd95fe
Compare
Member
Author
|
3 passes, removing debug info |
Jakob-Naucke
force-pushed
the
gha-kubevirt
branch
from
ffd95fe to
7b3b8a6
Compare
Member
Author
|
Opening for review. To reviewers: This reuses some commits identified in #285, but I'm still opening it now because the feedback loop for making KubeVirt-on-KinD-GHA work is much quicker than Azure-on-OpenShift-CI. |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- In
tools/virtctl/go.modthego 1.25.0directive targets a Go version that is not yet generally available; consider aligning this with a currently supported Go release to avoidgo list/tooling failures when working in that module.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `tools/virtctl/go.mod` the `go 1.25.0` directive targets a Go version that is not yet generally available; consider aligning this with a currently supported Go release to avoid `go list`/tooling failures when working in that module.
## Individual Comments
### Comment 1
<location path="Makefile" line_range="21" />
<code_context>
YQ_VERSION ?= $(shell go list -m -f '{{.Version}}' github.com/mikefarah/yq/v4)
YQ ?= $(LOCALBIN)/yq-$(YQ_VERSION)
-KOPIUM_VERSION ?= $(shell grep kopium lib/Cargo.toml | sed -E 's/.*"(.*)"/\1/')
+KOPIUM_VERSION ?= $(shell cargo metadata --format-version 1 | jq -r '.resolve.nodes[] | select(.deps[]?.name == "kopium") | .deps[] | select(.name == "kopium") | .pkg | split("@")[1]')
KOPIUM ?= $(LOCALBIN)/kopium-$(KOPIUM_VERSION)
</code_context>
<issue_to_address>
**suggestion (performance):** Using `cargo metadata` + `jq` here introduces extra tooling requirements and may slow down repeated Make invocations.
This approach is nicer than grepping Cargo.toml, but it does mean:
- `jq` must be installed, and
- `cargo metadata` runs on every evaluation, which can noticeably slow CI or frequent `make` runs.
Consider either caching `KOPIUM_VERSION` via a helper script/Make target so it’s computed once and reused, or providing a simpler fallback (e.g., the previous approach) when `jq`/`cargo` aren’t available to keep `make` usable in minimal environments.
```suggestion
KOPIUM_VERSION := $(shell cargo metadata --format-version 1 2>/dev/null \
| jq -r '.resolve.nodes[] | select(.deps[]?.name == "kopium") | .deps[] | select(.name == "kopium") | .pkg | split("@")[1]' 2>/dev/null \
|| grep kopium lib/Cargo.toml | sed -E 's/.*"(.*)"/\1/')
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| YQ_VERSION ?= $(shell go list -m -f '{{.Version}}' github.com/mikefarah/yq/v4) | ||
| YQ ?= $(LOCALBIN)/yq-$(YQ_VERSION) | ||
| KOPIUM_VERSION ?= $(shell grep kopium lib/Cargo.toml | sed -E 's/.*"(.*)"/\1/') | ||
| KOPIUM_VERSION ?= $(shell cargo metadata --format-version 1 | jq -r '.resolve.nodes[] | select(.deps[]?.name == "kopium") | .deps[] | select(.name == "kopium") | .pkg | split("@")[1]') |
There was a problem hiding this comment.
suggestion (performance): Using cargo metadata + jq here introduces extra tooling requirements and may slow down repeated Make invocations.
This approach is nicer than grepping Cargo.toml, but it does mean:
jqmust be installed, andcargo metadataruns on every evaluation, which can noticeably slow CI or frequentmakeruns.
Consider either caching KOPIUM_VERSION via a helper script/Make target so it’s computed once and reused, or providing a simpler fallback (e.g., the previous approach) when jq/cargo aren’t available to keep make usable in minimal environments.
Suggested change
| KOPIUM_VERSION ?= $(shell cargo metadata --format-version 1 | jq -r '.resolve.nodes[] | select(.deps[]?.name == "kopium") | .deps[] | select(.name == "kopium") | .pkg | split("@")[1]') | |
| KOPIUM_VERSION := $(shell cargo metadata --format-version 1 2>/dev/null \ | |
| | jq -r '.resolve.nodes[] | select(.deps[]?.name == "kopium") | .deps[] | select(.name == "kopium") | .pkg | split("@")[1]' 2>/dev/null \ | |
| || grep kopium lib/Cargo.toml | sed -E 's/.*"(.*)"/\1/') |
for CI installation & dependabot autoupdates Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
This reverts commit cc6bf85. Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
or it may not be deleted, plus a spell fix Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
Jakob-Naucke
force-pushed
the
gha-kubevirt
branch
from
7b3b8a6 to
fed91ca
Compare
Member
Author
|
we got #285 merged and this is rebased (10 -> 5 commits) |
alicefr
reviewed
Jun 26, 2026
Member
Author
|
control plane didn't come up on the CI that this PR intends to replace /retest |
Also tests fine with 500m, which aligns better with how much compute we get on GHA. Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
avoiding maintenance and lack of parallelization on a CI host & scripting logic in openshift-ci Signed-off-by: Jakob Naucke <jnaucke@redhat.com> Assisted-by: Opus 4.6
Jakob-Naucke
force-pushed
the
gha-kubevirt
branch
from
fed91ca to
7979f4d
Compare
alicefr
approved these changes
Jun 26, 2026
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alicefr, Jakob-Naucke The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Member
Author
|
thanks for your review @alicefr. let's wait this run again and if it succeeds, I'll merge and raise the removal in openshift-release (-3kloc) |
Jakob-Naucke
merged commit de12968
into
trusted-execution-clusters:main
11 checks passed
This was referenced Jun 26, 2026
Jakob-Naucke
added a commit
to Jakob-Naucke/openshift-release
that referenced
this pull request
Jun 29, 2026
Test relied on moving PR code to another host and running KinD there, which has been superseded by running on GHA trusted-execution-clusters/operator#287. Keeping basic structure for trusted-execution-clusters because we still intend to utilize OpenShift on openshift#79393. Signed-off-by: Jakob Naucke <jnaucke@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Refactor integration tests and supporting utilities to use Kubernetes await-based conditions and stricter cleanup, enhance operator installation error handling and logging, add configuration for KubeVirt VM CPU requirements, and introduce a GitHub Actions workflow and supporting Go module to run KubeVirt-based integration tests in CI.
Enhancements:
CI:
Documentation:
Tests: